On Mon, 2008-07-28 at 13:25 -0300, Ramon de Carvalho Valle wrote:
> Hi Subrata,
>
> According to robust futexes documentation, at the time of writing, only
> i386 and x86_64 are supported, other architectures doesn't have these
> system calls yet. The attached patch contains the testcases with
> suggested modifications.
Thanks for resending the patch. Here is the updated results as well:
1) Linux 2.6.9-74.EL #1 Tue Jun 17 16:42:36 EDT 2008 i686 athlon i386
GNU/Linux
BUILD=Skip,
INSTALL=Skip,
RUN=Exec Error below:
initiation_status="pan(30028): execvp of 'get_robust_list01' (tag
get_robust_list01) failed. errno:2 No such file or directory"
initiation_status="pan(30028): execvp of 'set_robust_list01' (tag
set_robust_list01) failed. errno:2 No such file or directory"
2) Linux 2.6.18-91.el5 #1 SMP Tue Apr 22 17:43:57 EDT 2008 x86_64 x86_64
x86_64 GNU/Linux
BUILD=Pass,
INSTALL=Pass,
Run=Pass,
get_robust_list01 1 PASS : get_robust_list: retval = -1 (expected
-1), errno = 14 (expected 14)
get_robust_list01 2 PASS : get_robust_list: retval = -1 (expected
-1), errno = 14 (expected 14)
get_robust_list01 3 PASS : get_robust_list: retval = -1 (expected
-1), errno = 3 (expected 3)
get_robust_list01 4 PASS : get_robust_list: retval = -1 (expected
-1), errno = 1 (expected 1)
get_robust_list01 5 PASS : get_robust_list: retval = 0 (expected
0), errno = 0 (expected 0)
set_robust_list01 1 PASS : set_robust_list: retval = -1 (expected
-1), errno = 22 (expected 22)
set_robust_list01 2 PASS : set_robust_list: retval = 0 (expected
0), errno = 0 (expected 0)
3) Linux 2.6.9-22.EL #1 SMP Mon Sep 19 17:52:20 EDT 2005 ppc64 ppc64
ppc64 GNU/Linux
BUILD=Skip,
INSTALL=Skip,
RUN=Exec Error below:
initiation_status="pan(30028): execvp of 'get_robust_list01' (tag
get_robust_list01) failed. errno:2 No such file or directory"
initiation_status="pan(30028): execvp of 'set_robust_list01' (tag
set_robust_list01) failed. errno:2 No such file or directory"
4) Linux 2.4.21-37.ELsmp #1 SMP Wed Sep 7 13:28:55 EDT 2005 i686 i686
i386 GNU/Linux
BUILD=Skip,
INSTALL=Skip,
RUN=Exec Error below:
initiation_status="pan(30028): execvp of 'get_robust_list01' (tag
get_robust_list01) failed. errno:2 No such file or directory"
initiation_status="pan(30028): execvp of 'set_robust_list01' (tag
set_robust_list01) failed. errno:2 No such file or directory"
5) Linux 2.6.18-91.el5 #1 SMP Tue Apr 22 17:48:59 EDT 2008 ppc64 ppc64
ppc64 GNU/Linux
BUILD=Pass,
INSTALL=Pass,
Run=Pass,
get_robust_list01 1 PASS : get_robust_list: retval = -1 (expected
-1), errno = 14 (expected 14)
get_robust_list01 2 PASS : get_robust_list: retval = -1 (expected
-1), errno = 14 (expected 14)
get_robust_list01 3 PASS : get_robust_list: retval = -1 (expected
-1), errno = 3 (expected 3)
get_robust_list01 4 PASS : get_robust_list: retval = -1 (expected
-1), errno = 1 (expected 1)
get_robust_list01 5 PASS : get_robust_list: retval = 0 (expected
0), errno = 0 (expected 0)
set_robust_list01 1 PASS : set_robust_list: retval = -1 (expected
-1), errno = 22 (expected 22)
set_robust_list01 2 PASS : set_robust_list: retval = 0 (expected
0), errno = 0 (expected 0)
6) Linux 2.6.18-91.el5PAE #1 SMP Tue Apr 22 17:58:37 EDT 2008 i686
athlon i386 GNU/Linux
BUILD=Pass,
INSTALL=Pass,
Run=Pass,
get_robust_list01 1 PASS : get_robust_list: retval = -1 (expected
-1), errno = 14 (expected 14)
get_robust_list01 2 PASS : get_robust_list: retval = -1 (expected
-1), errno = 14 (expected 14)
get_robust_list01 3 PASS : get_robust_list: retval = -1 (expected
-1), errno = 3 (expected 3)
get_robust_list01 4 PASS : get_robust_list: retval = -1 (expected
-1), errno = 1 (expected 1)
get_robust_list01 5 PASS : get_robust_list: retval = 0 (expected
0), errno = 0 (expected 0)
set_robust_list01 1 PASS : set_robust_list: retval = -1 (expected
-1), errno = 22 (expected 22)
set_robust_list01 2 PASS : set_robust_list: retval = 0 (expected
0), errno = 0 (expected 0)
7) Linux 2.6.25-gcov-nomodconfig-smp #1 SMP Thu Jun 12 06:29:27 EDT 2008
i686 i686 i386 GNU/Linux
BUILD=Skip,
INSTALL=Skip,
RUN=Exec Error below:
initiation_status="pan(30028): execvp of 'get_robust_list01' (tag
get_robust_list01) failed. errno:2 No such file or directory"
initiation_status="pan(30028): execvp of 'set_robust_list01' (tag
set_robust_list01) failed. errno:2 No such file or directory"
My Observations:
1) All Build/Install issues has been taken care off,
2) The running of the test cases still needs to be addressed. Since you
are not building/installing on unsupported systems, the same has to be
handled with proper messages. You can do this by either:
a) Including #IFDEFS inside the *.c code,
b) Creating a run script which installs and runs, and then checks the
support during run and throws appropriate messages. You can see this for
reference:
http://marc.info/?l=ltp-list&m=121784565925214&w=2,
Hope you will work on this and resend me an updated patch.
Regards--
Subrata
>
> Best regards,
>
>
> On Sat, 2008-07-26 at 19:32 +0530, Subrata Modak wrote:
> > Michael,
> >
> > Would you like to review Ramon´s test cases on get_robust_list() and
> > set_robust_list() ?
> >
> > Hi Ramon,
> >
> > Here are my small observations of the patch:
> >
> > 1) You have disabled compiling the testcases: get_robust_list01.c and
> > set_robust01.c through ltp/testcases/kernel/syscalls/Makefile. I am not
> > sure what purpose does it serve in adding the syscall tests when you do
> > not want to compile/install/run them. And also a entry for both
> > get_robust_list01 and set_robust list01 is missing from
> > runtest/syscalls. I hope in your next patch you will compile this by
> > deafult and also include an entry to run them along with other syscalls.
> >
> > I enabled the test cases to build/install and run, and following are my
> > observations when i ran them across some architectures:
> >
> > 1) Linux 2.6.18-92.el5 #1 SMP Tue Apr 29 13:16:12 EDT 2008 i686 i686
> > i386 GNU/Linux
> > BUILD=PASS, INSTALL=PASS, RUN=PASS
> >
> > 2) Linux 2.6.18-91.el5 #1 SMP Tue Apr 22 17:43:57 EDT 2008 x86_64 x86_64
> > x86_64 GNU/Linux
> > BUILD=PASS, INSTALL=PASS, RUN=PASS
> >
> > 3) Linux 2.6.18-91.el5 #1 SMP Tue Apr 22 17:48:59 EDT 2008 ppc64 ppc64
> > ppc64 GNU/Linux
> > BUILD=PASS, INSTALL=PASS, RUN=PASS
> >
> >
> > 4) Linux 2.6.25-gcov-nomodconfig-smp #1 SMP Thu Jun 12 06:29:27 EDT 2008
> > i686 i686 i386 GNU/Linux
> > BUILD=FAIL,
> > 5) Linux 2.6.9-42.ELsmp #1 SMP Wed Jul 12 23:32:02 EDT 2006 x86_64
> > x86_64 x86_64 GNU/Linux
> > BUILD=FAIL
> > 6) Linux 2.6.9-42.EL #1 SMP Wed Jul 12 23:22:51 EDT 2006 ppc64 ppc64
> > ppc64 GNU/Linux
> > BUILD=FAIL
> > 7) Linux 2.6.16.21-0.8-default #1 SMP Mon Jul 3 18:25:39 UTC 2006 ia64
> > ia64 ia64 GNU/Linux
> > BUILD=FAIL
> >
> >
> > Following are the error messages when they failed:
> >
> > cc -Wall -I../../include -g -Wall -I../../../../include -Wall
> > get_robust_list01.c -L../../../../lib -lltp -o get_robust_list01
> > get_robust_list01.c: In function ‘main’:
> > get_robust_list01.c:75: error: storage size of ‘head’ isn’t known
> > get_robust_list01.c:87: error: invalid application of ‘sizeof’ to
> > incomplete type ‘struct robust_list_head’
> > get_robust_list01.c:100: error: ‘__NR_get_robust_list’ undeclared (first
> > use in this function)
> > get_robust_list01.c:100: error: (Each undeclared identifier is reported
> > only once
> > get_robust_list01.c:100: error: for each function it appears in.)
> > get_robust_list01.c:75: warning: unused variable ‘head’
> > make[4]: *** [get_robust_list01] Error 1
> >
> >
> > cc -Wall -I../../include -g -Wall -I../../../../include -Wall
> > set_robust_list01.c -L../../../../lib -lltp -o set_robust_list01
> > set_robust_list01.c: In function ‘main’:
> > set_robust_list01.c:75: error: storage size of ‘head’ isn’t known
> > set_robust_list01.c:87: error: invalid application of ‘sizeof’ to
> > incomplete type ‘struct robust_list_head’
> > set_robust_list01.c:97: error: ‘__NR_set_robust_list’ undeclared (first
> > use in this function)
> > set_robust_list01.c:97: error: (Each undeclared identifier is reported
> > only once
> > set_robust_list01.c:97: error: for each function it appears in.)
> > set_robust_list01.c:75: warning: unused variable ‘head’
> > make[4]: *** [set_robust_list01] Error 1
> >
> >
> > I think you need to include some code which handles stuff like
> > header/library/support checking in the Makefile, so that it aborts
> > compilation and hence install due to lack of this.
> >
> > But in all instances you should be able to showup proper message(s) to
> > the user when your test cases is not compiled/installed, but is run
> > (this will definitely happen when executing runtest/syscalls). You may
> > want to see the following thread how Vijay has handled it in his
> > move_pages() syscall tests.
> >
> > Hope to see an updated patch from you soon.
> >
> > Regards--
> > Subrata
> >
> > -------- Forwarded Message --------
> > From: Ramon de Carvalho Valle <[EMAIL PROTECTED]>
> > Reply-To: [EMAIL PROTECTED]
> > To: [email protected]
> > Subject: [LTP] [PATCH] New testcases for get_robust_list and
> > set_robust_list system calls
> > Date: Fri, 25 Jul 2008 16:23:56 -0300
> >
> > Hi,
> >
> > The attached patch contains new testcases for get_robust_list and
> > set_robust_list system calls.
> >
> > Best regards,
> >
> >
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > Build the coolest Linux based applications with Moblin SDK & win great
> > prizes
> > Grand prize is a trip for two to an Open Source event anywhere in the world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________ Ltp-list mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/ltp-list
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
