Hi,

> > <3> It seems that test cases for foo16, foo and foo64 prints the
> >     result in the same format like:
> > 
> 
> Can you work on this before any other thing (my request), as this fix
> will give way to handle similar stuff for the _16 and _64 test cases.
> Just few thoughts from my side.


How about introducing TCID_DEFINE?

I'm not sure puttint TCID_DEFINE macro to test.h.
I'm not sure using a symbol as an argument for TCID_DEFINE macro 
is better than using a string. (I had strong lisp backgroud:-)

If this acceptable, I'll update related documents and
test cases I worked.

Signed-off-by: Masatake YAMATO <[EMAIL PROTECTED]> 

Index: include/test.h
===================================================================
RCS file: /cvsroot/ltp/ltp/include/test.h,v
retrieving revision 1.13
diff -u -r1.13 test.h
--- include/test.h      6 May 2008 15:47:54 -0000       1.13
+++ include/test.h      19 Aug 2008 02:08:41 -0000
@@ -241,6 +241,19 @@
 extern int tst_is_cwd_tmpfs();
 extern int tst_cwd_has_free(int required_kib);
 
+
+
+#ifdef TST_USE_COMPAT16_SYSCALL
+#define TCID_BIT_SUFFIX "_16"
+#elif  TST_USE_NEWER64_SYSCALL
+#define TCID_BIT_SUFFIX "_64"
+#else
+#define TCID_BIT_SUFFIX ""
+#endif
+#define TCID_DEFINE(ID) \
+  char *TCID = (#ID TCID_BIT_SUFFIX)
+
+
 extern int Tst_count;
 
 /* self_exec.c functions */
Index: testcases/kernel/syscalls/setgid/Makefile
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/setgid/Makefile,v
retrieving revision 1.8
diff -u -r1.8 Makefile
--- testcases/kernel/syscalls/setgid/Makefile   4 Aug 2008 12:06:21 -0000       
1.8
+++ testcases/kernel/syscalls/setgid/Makefile   19 Aug 2008 02:09:21 -0000
@@ -25,7 +25,7 @@
 
 %.c: compat_16.h
 %_16.c: %.c 
-       echo "#define USE_COMPAT16_SYSCALL 1" > $@
+       echo "#define TST_USE_COMPAT16_SYSCALL 1" > $@
        cat $< >> $@
 
 
Index: testcases/kernel/syscalls/setgid/compat_16.h
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/setgid/compat_16.h,v
retrieving revision 1.1
diff -u -r1.1 compat_16.h
--- testcases/kernel/syscalls/setgid/compat_16.h        4 Aug 2008 12:06:21 
-0000       1.1
+++ testcases/kernel/syscalls/setgid/compat_16.h        19 Aug 2008 02:09:21 
-0000
@@ -27,7 +27,7 @@
 #include "linux_syscall_numbers.h"
 
 
-#ifdef USE_COMPAT16_SYSCALL
+#ifdef TST_USE_COMPAT16_SYSCALL
 typedef __kernel_old_gid_t GID_T;
 int 
 COMPAT_SIZE_CHECK(gid_t gid)
Index: testcases/kernel/syscalls/setgid/setgid01.c
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/setgid/setgid01.c,v
retrieving revision 1.3
diff -u -r1.3 setgid01.c
--- testcases/kernel/syscalls/setgid/setgid01.c 4 Aug 2008 12:06:21 -0000       
1.3
+++ testcases/kernel/syscalls/setgid/setgid01.c 19 Aug 2008 02:09:21 -0000
@@ -120,7 +120,7 @@
 
 #include "compat_16.h"
 
-char *TCID="setgid01";                 /* Test program identifier.    */
+TCID_DEFINE(setgid01);          /* Test program identifier.    */
 int TST_TOTAL=1;               /* Total number of test cases. */
 extern int Tst_count;          /* Test Case counter for tst_* routines */
 

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to