On Thu, 2008-08-28 at 09:37 -0700, Garrett Cooper wrote: > On Wed, Aug 27, 2008 at 11:53 PM, Gilles Carry <[EMAIL PROTECTED]> wrote: > > > > > > Daniel Gollub wrote: > > > Fully agree on this. > >> > >> Gilles, Darren, is there any objection to revert the "CFLAGS += -m64" > >> line? > >> > >> Currently i have to patch this change out of the build environment to have > >> a > >> proper build on i586. Since -m64 just gets appended on the user-defined > >> CLFAGS > >> and there is no way to overwrite -m64 without touching the build > >> environment. > >> > > > > I don't mind reverting this patch. > > I the beginning, I just asked what would be the accepted solution. So I sent > > the patch I'm currently using to show what I missed but did not expect it to > > be applied without any discussion. > > This CFLAGS setting could be conditional (a script switch or whatever) or be > > env-exported before running any test. > > If I understood well, the latter is Garrett's opinion, isn't it? > > > > Gilles. > > Before executing any make, yes. That's what it should be IMHO.
Certainly no objection from me on removing. Garret, what then would be the new way to build? $ CROSS_CFLAGS=-m64 make Something like the above? > > -Garrett -- Darren Hart Real-Time Linux Team Lead IBM Linux Technology Center ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
