On Sun, 2008-09-14 at 23:10 +0200, Robert Schwebel wrote: > Hi, > > While working on more or less proper cross compilation support for LTP > in ptxdist, I've come over the fact again that rttests is breaking down > hard if not being built on x86 or powerpc (in fact, I'm wondering if > there is any policy at all for code to be included in LTP - it has no > unique coding style, Makefiles are crappy as hell, the documentation in > rttests/ still refers to the autotool based Makefiles although they have > been replaced long ago, and code seems to be applied to LTP although it > not even tries to survive compilation on more than x86+ppc :-/ ). > > The function in question is the rdtsc() macro in include/librttest.h. It > looks like the tests are trying to derive tsc deltas from consecutive > reads; however, since tglx' work on timing in the Linux mainline we > know that TSCs can have any crappiness on earth - so why are they being > used here? Do these tests make any sense at all?
Robert, I can't speak for all of LTP but re. the realtime tests, thanks for the input on the docs, I'll raise this with my team and try to get a patch out to remedy that quickly. As to the rdtsc bits, I'm not sure those tests need to remain in LTP (anyone have strong feelings here?). We used them internally during some debugging sessions and they carried over into the package eventually incorporated into LTP. You mentioned the "crapiness" of the Makefiles in LTP. The realtime Makefiles have been overhauled a couple of times, other than the cruft left over from the autotool-ectomy do you have any problems with the current Makefiles? Thanks, Darren > > However, I'm preparing a patch to make at least the *rest* of the test > cases (and of LTP at all) survive the compilation stage on non-x86/ppc. > > Thanks, > rsc -- Darren Hart Real-Time Linux Team Lead IBM Linux Technology Center ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
