On Mon, 2008-10-20 at 21:08 -0700, CAI Qian wrote: > Hi, > > I have one concern about this part, > > diff --git a/testcases/network/iptables/iptables_tests.sh > b/testcases/network/iptables/iptables_tests.sh > --- a/testcases/network/iptables/iptables_tests.sh > +++ b/testcases/network/iptables/iptables_tests.sh > @@ -61,7 +61,7 @@ > # Initialize cleanup function. > trap "cleanup" 0
> > tst_resm TINFO "$TCID: Deleting the rule to log." > - iptables -D INPUT 1 &>$LTPTMP/tst_iptables.out || RC=$? > + iptables -D INPUT 1 > $LTPTMP/tst_iptables.out 2>&1 || RC=$? > if [ $RC -ne 0 ]; then > tst_res TFAIL $LTPTMP/tst_iptables.out \ > "$TCID: iptables did not remove the rule. Reason:" > > As all "local" keywords has been removed, is it possible that those variable > have been reused > unexpectedly later? Otherwise, all those patches look good, and seems not > break any existing > functionality. > I hope you have tested them well. If something intrudes, you can rectify and send me the patch later. Nothing withstanding this is merged. Regards-- Subrata > Cai Qian ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
