On Tuesday 21 October 2008, Jiri Palecek wrote: > On Tuesday 21 October 2008 10:20:24 Mike Frysinger wrote: > > On Tuesday 21 October 2008, CAI Qian wrote: > > > diff --git a/testcases/network/iptables/iptables_tests.sh > > > b/testcases/network/iptables/iptables_tests.sh > > ... snipped part of a patch removing the use of "local" keyword ... > > > > As all "local" keywords has been removed, is it possible that those > > > variable have been reused unexpectedly later? Otherwise, all those > > > patches look good, and seems not break any existing functionality. > > > > did you actually hit an issue with the usage of "local" ? while it isnt > > in POSIX, there has yet to be anyone to use a real shell that doesnt > > support it. considering the bugs it prevents, it should stay if you dont > > have a real case. > > The issue I was solving when making this patch was checkbashisms > (http://packages.debian.org/sid/devscripts) complaining about it, so I had > to patch it to get rid of lintian warnings.
this is exactly the sort of behavior i dont want people applying to projects > I've checked that > > - the variables are always initialised before use in the testXX functions > - the testXX functions don't recurse nor call each other > - the variables are not used outside testXX functions while that's good now, it's a huge pain to do that validation everytime a change is needed > so IIUC, the transformation should be safe. However, if you're seriously > worried about it, you can reintroduce the locals by applying the attached > patch, it wouldn't matter to me. that would be best, thanks -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
