On Wednesday 10 December 2008 20:34:03 Jiří Paleček wrote:
> the tst_brk function doesn't print anything when Tst_count>=TST_TOTAL.

tests shouldnt be calling tst_brk() when tst_count == TST_TOTAL, and tst_count 
should never get above TST_TOTAL.  we should add a sanity/assert test to 
tst_exit() for this i think.

what tests are you seeing this with ?

> The attached patch changes this behaviour, to prevent silent test failures.

sounds fine in general ... ignoring the previous comments

> See the patch for comment.

you're clearly using `git` ... why arent you using `git send-email` ?  that'll 
post the patch properly inline so it can easily be reviewed.  sticking a patch 
in an e-mail and then attaching that e-mail to another e-mail isnt easy to 
review ...
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to