Hi Németh, Did you find time to prepare a new patch as per Mike´s comments. I think, with that we might me able to complete cleaning the LTP device drivers Makefile(s) - another step forward in making them actually build/install compatible with the latest kernel(s) ;-) Thanks for the good work.
Regards-- Subrata On Sat, 2009-02-28 at 16:40 -0500, Mike Frysinger wrote: > On Saturday 28 February 2009 16:24:26 Németh Márton wrote: > > ltp/testcases/kernel/device-drivers/acpi/Makefile > > > > default: > > $(MAKE) -C $(KDIR) SUBDIRS=$(PWD) modules > > - gcc $(CFLAGS) -o LtpAcpiMain LtpAcpiMain.c > > + $(CC) $(CFLAGS) -o LtpAcpiMain LtpAcpiMain.c > > use make's implicit rules instead: > default: LtpAcpiMain > > > ltp/testcases/kernel/device-drivers/agp/user_space/Makefile > > > > test_agp: tagp_ki.o user_tagp.o > > - gcc tagp_ki.o user_tagp.o -o test_agp > > + $(CC) tagp_ki.o user_tagp.o -o test_agp > > $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $^ > > > tagp_ki.o: tagp_ki.c > > - gcc -c tagp_ki.c > > + $(CC) -c tagp_ki.c > > > > user_tagp.o: user_tagp.c > > - gcc -c user_tagp.c > > + $(CC) -c user_tagp.c > > useless rules -- just delete them > > > ltp/testcases/kernel/device-drivers/base/user_base/Makefile > > > > test_base: tbase_ki.o user_tbase.o > > - gcc tbase_ki.o user_tbase.o -o test_base > > + $(CC) tbase_ki.o user_tbase.o -o test_base > > > > tbase_ki.o: tbase_ki.c > > - gcc -c tbase_ki.c > > + $(CC) -c tbase_ki.c > > > > user_tbase.o: user_tbase.c > > - gcc -c user_tbase.c > > + $(CC) -c user_tbase.c > > same comments as above > > > ltp/testcases/kernel/device-drivers/dev_sim_framework/user_space/Makefile > > > > test_mod: tmod_ki.o user_tmod.o > > - gcc tmod_ki.o user_tmod.o -o test_mod > > + $(CC) tmod_ki.o user_tmod.o -o test_mod > > > > tmod_ki.o: tmod_ki.c > > - gcc -c tmod_ki.c > > + $(CC) -c tmod_ki.c > > > > user_tmod.o: user_tmod.c > > - gcc -c user_tmod.c > > + $(CC) -c user_tmod.c > > same comments as above > > > ltp/testcases/kernel/device-drivers.orig/drm/user_space/Makefile > > > > default: > > - gcc -o test_drm user_tdrm.c $(CFLAGS) > > + $(CC) -o test_drm user_tdrm.c $(CFLAGS) > > this rule just sucks and should be rewritten > > > ltp/testcases/kernel/device-drivers/include/Makefile > > > > default: > > $(MAKE) -C $(KDIR) SUBDIRS=$(PWD) modules > > - gcc -Wall -o userBlockInclude userBlockInclude.c > > + $(CC) -Wall -o userBlockInclude userBlockInclude.c > > use implicit rule: > default: userBlockInclude > > > ltp/testcases/kernel/device-drivers/nls/Makefile > > > > default: > > $(MAKE) -C $(KDIR) SUBDIRS=$(PWD) modules > > - gcc $(EXTRA_CFLAGS) -o userBlockNLS userBlockNLS.c > > + $(CC) $(EXTRA_CFLAGS) -o userBlockNLS userBlockNLS.c > > same comment as above > > > ltp/testcases/kernel/device-drivers/pci/user_tpci/Makefile > > > > test_pci: tpci_ki.o user_tpci.o > > - gcc tpci_ki.o user_tpci.o -o test_pci > > + $(CC) tpci_ki.o user_tpci.o -o test_pci > > $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $^ > > > tpci_ki.o: tpci_ki.c > > - gcc -c tpci_ki.c > > + $(CC) -c tpci_ki.c > > > > user_tpci.o: user_tpci.c > > - gcc -c user_tpci.c > > + $(CC) -c user_tpci.c > > useless rules -- just delete them > > > ltp/testcases/kernel/device-drivers/tbio/user_space/Makefile > > > > test_bio: tbio_ki.o user_tbio.o > > - gcc -g tbio_ki.o user_tbio.o -o test_bio > > + $(CC) -g tbio_ki.o user_tbio.o -o test_bio > > > > tbio_ki.o: tbio_ki.c > > - gcc -c -g tbio_ki.c > > + $(CC) -c -g tbio_ki.c > > > > user_tbio.o: user_tbio.c > > - gcc -c -g user_tbio.c > > + $(CC) -c -g user_tbio.c > > same comments as above > > > ltp/testcases/kernel/device-drivers/usb/user_usb/Makefile > > > > test_usb: tusb_ki.o user_tusb.o > > - gcc tusb_ki.o user_tusb.o -o test_usb > > + $(CC) tusb_ki.o user_tusb.o -o test_usb > > > > tusb_ki.o: tusb_ki.c > > - gcc -c tusb_ki.c > > + $(CC) -c tusb_ki.c > > > > user_tusb.o: user_tusb.c > > - gcc -c user_tusb.c > > + $(CC) -c user_tusb.c > > same comments as above > -mike ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
