On Wednesday 04 March 2009 02:42:17 Németh Márton wrote:
> +CFLAGS = -O2 -Wall -Wextra

CFLAGS should always be appended, not set.  optimization flags should never be 
added.  -Wextra will cause failures with gcc-3.3 and older.

> +clean:
> +     rm -f $(OBJS)
> +     rm -f test_agp

no point in calling `rm` twice ...

looks like those comments apply to every Makefile here

otherwise looks fine, thanks
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to