Hi,
On Mon, 2009-05-18 at 15:58 +0200, Cyril Hrubis wrote:
> Hi,
> these three patches fixes missing return 0; statements.
>
> Signed-off-by: Cyril Hrubis [email protected]
>
> --
> Cyril Hrubis
> [email protected]
>
>
>
>
>
>
>
>
>
>
>
> differences
> between files
> attachment
> (fix-main-return-value.patch)
>
>
> Index: ltp-full-20090430/testcases/kernel/io/aio/aio02/main.c
> ===================================================================
> --- ltp-full-20090430.orig/testcases/kernel/io/aio/aio02/main.c
> +++ ltp-full-20090430/testcases/kernel/io/aio/aio02/main.c
> @@ -34,7 +34,9 @@ int TST_TOTAL=0;
>
> int main(void)
> {
> - tst_brkm(TCONF, tst_exit, "libaio missing");
> + tst_brkm(TCONF, tst_exit, "libaio missing");
> +
> + return 0;
This is not necessary as tst_exit() will automatically return
appropriate value depending on whether it is TCONF, TPASS, TFAIL, etc.
And for TCONF it already returns 0.
Probably you will get a build warning saying:
Noting returns although prototype says something should return.
> }
>
> #endif
>
>
>
>
>
>
>
>
>
>
>
> differences
> between files
> attachment
> (fix-aio01-return-value.patch)
>
>
> Index: ltp-full-20090430/testcases/kernel/io/aio/aio01/aio01.c
> ===================================================================
> --- ltp-full-20090430.orig/testcases/kernel/io/aio/aio01/aio01.c
> +++ ltp-full-20090430/testcases/kernel/io/aio/aio01/aio01.c
> @@ -426,7 +426,9 @@ void cleanup() {
>
> int main(void)
> {
> - tst_brkm(TCONF, tst_exit, "libaio missing");
> + tst_brkm(TCONF, tst_exit, "libaio missing");
> +
> + return 0;
Same as above.
> }
>
> #endif
>
>
>
>
>
>
>
>
>
>
>
> differences
> between files
> attachment
> (fix-ima_mmap-return-value.patch)
>
>
> Index:
> ltp-full-20090430/testcases/kernel/security/integrity/ima/src/ima_mmap.c
> ===================================================================
> ---
> ltp-full-20090430.orig/testcases/kernel/security/integrity/ima/src/ima_mmap.c
> +++
> ltp-full-20090430/testcases/kernel/security/integrity/ima/src/ima_mmap.c
> @@ -48,4 +48,6 @@ int main(int argc, char *argv[])
> perror("unmap");
> return(-1);
> }
> +
> + return 0;
This is fine.
Regards--
Subrata
> }
>
> ------------------------------------------------------------------------------
> Crystal Reports - New Free Runtime and 30 Day Trial
> Check out the new simplified licensing option that enables
> unlimited royalty-free distribution of the report engine
> for externally facing server and web deployment.
> http://p.sf.net/sfu/businessobjects
> _______________________________________________
> Ltp-list mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ltp-list
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables
unlimited royalty-free distribution of the report engine
for externally facing server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
