On Thu, 2009-05-21 at 14:25 +0200, Cyril Hrubis wrote:
> Hi,
> > > int main(void)
> > > {
> > > - tst_brkm(TCONF, tst_exit, "libaio missing");
> > > + tst_brkm(TCONF, tst_exit, "libaio missing");
> > > +
> > > + return 0;
> >
> > This is not necessary as tst_exit() will automatically return
> > appropriate value depending on whether it is TCONF, TPASS, TFAIL, etc.
> > And for TCONF it already returns 0.
> >
> > Probably you will get a build warning saying:
> >
> > Noting returns although prototype says something should return.
>
> Well it breaks building suse rpm package as buildservice system treats these
> kind of warning as errors and it's IMHO harmless to add these returns in the
> code.
Strange. But, in LTP convention, tst_exit() is used which in turn does a
return $EXIT_CODE on itś own. We do not interfere. return 0/1 exists in
LTP code only when we have not detected that, or, it has been lying
there old. Else, for new tests and when submitting patches we convert
all returns to tst_exit().
Regards--
Subrata
>
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://www.creativitycat.com
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
