On Sat, 2009-07-18 at 21:38 -0700, Garrett Cooper wrote:
> For whatever reason the original author was using int casts to the
> strerror strings. That's just plain wrong...
>
> This corrects the issue by feeding back the proper strerror output,
> which reduces noise at compile time and results in the same desired
> behavior (because we shouldn't be negative testing strerror(3) in
> waitid01.c:
>
> gcoo...@orangebox /scratch/ltp-nova2/ltp-nova $
> /scratch/ltp-nova2/ltp-nova/testcases/kernel/syscalls/waitid/waitid01
> waitid01 0 INFO : Process 29085 terminated:
> waitid01 0 INFO : code = 1
> waitid01 0 INFO : exit value = 123
> waitid01 0 INFO : Process 29086 terminated:
> waitid01 0 INFO : code = 2
> waitid01 0 INFO : signal = 8
> waitid01 0 INFO : Process 29087 terminated:
> waitid01 0 INFO : code = 2
> waitid01 0 INFO : signal = 1
> waitid01 0 INFO : Process 29088 terminated:
> waitid01 0 INFO : code = 1
> waitid01 0 INFO : exit value = 123
> waitid01 0 INFO : Process 29089 terminated:
> waitid01 0 INFO : code = 2
> waitid01 0 INFO : signal = 8
> waitid01 0 INFO : Process 29090 terminated:
> waitid01 0 INFO : code = 2
> waitid01 0 INFO : signal = 1
> waitid01 0 INFO : Process 29091 terminated:
> waitid01 0 INFO : code = 1
> waitid01 0 INFO : exit value = 123
> waitid01 0 INFO : Process 29092 terminated:
> waitid01 0 INFO : code = 2
> waitid01 0 INFO : signal = 8
> waitid01 0 INFO : Process 29093 terminated:
> waitid01 0 INFO : code = 2
> waitid01 0 INFO : signal = 1
> waitid01 1 PASS : waitid(): system call passed
>
> Signed-off-by: Garrett Cooper <[email protected]>
I checked in this too. Thanks.
Regards--
Subrata
>
> Index: testcases/kernel/syscalls/waitid/waitid01.c
> ===================================================================
> RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/waitid/waitid01.c,v
> retrieving revision 1.1
> diff -u -r1.1 waitid01.c
> --- testcases/kernel/syscalls/waitid/waitid01.c 15 Jun 2009 18:39:45
> -0000 1.1
> +++ testcases/kernel/syscalls/waitid/waitid01.c 19 Jul 2009 04:34:39
> -0000
> @@ -116,14 +116,9 @@
> int errnochoose(void){ //choose the relative errno
>
> switch (TEST_ERRNO){
> - case 0: tst_exit();
> - case ECHILD: strerror((int)"ECHILD");
> - break;
> - case EINTR: strerror((int)"EINTR");
> - break;
> - case EINVAL: strerror((int)"EINVAL");
> - break;
> - default: strerror((int)"Other Error");
> + case 0: tst_exit();
> + break;
> + default: strerror(TEST_ERRNO);
> break;
> }
> TEST_RETURN = 0;
> ------------------------------------------------------------------------------
> Enter the BlackBerry Developer Challenge
> This is your chance to win up to $100,000 in prizes! For a limited time,
> vendors submitting new applications to BlackBerry App World(TM) will have
> the opportunity to enter the BlackBerry Developer Challenge. See full prize
> details at: http://p.sf.net/sfu/Challenge
> _______________________________________________ Ltp-list mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ltp-list
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list