Hi,

Test cases unshare failed to compile on systems without such a
syscall. I am unsure what the best way to handle it. The old ways are,

* add a kernel version check in the unshare tests code.

or

* add a m4 rule.
* modify the unshare tests code to check if the macro, and add stub
  functions if the macro is false.

The first approach is unable to handle non-vanilla kernels. The second
approach needs to add stub functions which are unclean. What I would
like to do is,

* add a m4 rule.
* modify unshare Makefile like this,

  ifdef HAVE_UNSHARE  <-- if the syscall is present, compile the tests.

  CFLAGS += -I../../../../include -Wall
  LDLIBS += -L../../../../lib -lltp

  SRCS    = $(wildcard *.c)
  TARGETS = $(patsubst %.c,%,$(SRCS))

  all: $(TARGETS)

  install:
          @set -e; for i in $(TARGETS); do ln -f $$i ../../../bin/$$i ; done

  else               <-- Otherwise, skip them.
  all:

However, I am not sure how to pass the HAVE_UNSHARE value to the
Makefile yet.

CAI Qian

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to