Serge E. Hallyn wrote: > Quoting Michal Simek ([email protected]): >> Hi Mike, >> >> I have one question about one your big patch >> >> http://git.kernel.org/?p=linux/kernel/git/galak/ltp.git;a=commitdiff;h=391dc18fe3271fbf2ca1864a5299f091c31e0018 >> >> My question is why you add -1 in lib/cloner.c:65 >> >> + ret = clone(fn, (stack ? stack + stack_size - 1 : NULL), >> + clone_flags, arg); >> >> In previous code in clone testcases was nothing like this. >> What reason have you had to add it? > > Because the same thing was done in lots of places all over the > testsuite (and done wrong). This consolidates them all.
I don't have anything against consolidation. I just want to know why there is that -1 which weren't in any clone testcases. Nothing more nothing less. Michal > >> Of course the reason is that on Microblaze some tests failed. > > How do they fail? Does clone on Microblaze take the top of > stack? > > -serge -- Michal Simek, Ing. (M.Eng) PetaLogix - Linux Solutions for a Reconfigurable World w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663 ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
