On Fri, Apr 2, 2010 at 11:59 AM, Cyril Hrubis <[email protected]> wrote: > Hi! > It looks (at least for me) that fs_perms tests are broken for a long time (as > they are trying to find binaries in working directory instead of LTPROOT). > > Attached patch fixes fs_perm.c to look for test binary in > $LTPROOT/testcases/bin/ rather than in ./ and converts silly and broken > fs_perms_simple.sh script into runtest file that is also added into runltp > script. > > > The way how now fs_perm is copying test file into temporary directory is not > ideall either because the test fails when executed by hand. I could think of > creating file with a such line: > > #!/bin/true > > Or maybe more robust: > > #!/bin/sh > true > > But I'm not sure if there is always /bin/true (as it's buildin in most of the > shells) or if I it's good idea to add dependecy for /bin/sh. But this would > avoid compiling dummy C program and copying it from $LTPROOT/testcases/bin/. > > Or we could do some trickery to embed the "dummy" binary file into the code as > array.
It could just be an empty file, or one with just a shebang. Example: [gcoo...@bayonetta ~]$ ./bar [gcoo...@bayonetta ~]$ echo $? 0 [gcoo...@bayonetta ~]$ cat bar #!/bin/sh `:' is an alternative to `true' too. > Any ideas here? > > > However the problem discussed above fs_perms tests are at least working with > this patch. > > Signed-off-by: Cyril Hrubis [email protected] Thanks, -Garrett ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
