On Fri, Apr 23, 2010 at 5:53 AM, Cyril Hrubis <[email protected]> wrote: > Hi! >> Okay, did some work on this and here comes the result: >> >> * tst_get_path() function is introduced for looking for >> binaries in $PATH. Notice that there is allready >> search_path() however this one tries to figure out path >> to the current runnig binary and has a little strange >> interface (is used only in some fcntl tests so should be >> easy to fix). >> >> * fs_test now tries to execute two different files instead >> of one. First one is empty and executed by execlp(). >> Second one contains shebang and is executed by execl(). >> This way we cover both kernel and libc codepath. >> >> + Various small fixups. >> >> Patch attached. >> >> Signed-off-by: Cyril Hrubis [email protected] >> > > Uff, the patch get mixed with ftestXX patch. This one should > be correct.
1. fclose, fprintf, etc aren't syscalls; they're libcalls. 2. MAX_PATH should be PATHNAME_MAX. 3. Using atoi(3) is a nasty mistake. Should be using strtol or atol. Other than that it looks fine. Thanks, -Garrett ------------------------------------------------------------------------------ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
