Hi Cyril, Do you wish to ack my patch ? Thanks, Gowrishankar
On Thursday 09 September 2010 01:49 PM, Subrata Modak wrote: > Can both of you agree to send a single patch ? > > Regards-- > Subrata > > On Mon, 2010-09-06 at 22:19 +0530, gowrishankar wrote: > >> On Monday 06 September 2010 09:46 PM, Subrata Modak wrote: >> >>> Darren/Gowri, >>> >>> Are you aware of this patch ? Can you please provide your comments ? >>> >>> >>> >> Subrata/Cyril, >> Apologies that I tagged this mail, but somehow forgot to reply >> immediately. >> >> I had already prepared a patch (before Cyril shared his part) to make >> atomic_add much more maintenance free and sharing with you guys now. >> Please find it attached. >> >> Thanks, >> Gowrishankar >> >> >>> Regards-- >>> Subrata >>> >>> On Thu, 2010-09-02 at 16:47 +0200, Cyril Hrubis wrote: >>> >>> >>>> Hi! >>>> The atomic_add() assembler for x86 is missing hint for gcc that value of >>>> v->counter is being modified by xaddl instruction and as this variable >>>> is changed only from this asm runtime, some combination of gcc >>>> optimalizations allows for this value to be placed in binary .rodata >>>> section resulting in realtime tests segfaulting when trying to do >>>> atomic_add(). It's reproducible on SLES11 (gcc 4.3.2) with -O2. >>>> >>>> Patch attached. >>>> >>>> Signed-off-by: Cyril Hrubis [email protected] >>>> >>>> ------------------------------------------------------------------------------ >>>> This SF.net Dev2Dev email is sponsored by: >>>> >>>> Show off your parallel programming skills. >>>> Enter the Intel(R) Threading Challenge 2010. >>>> http://p.sf.net/sfu/intel-thread-sfd >>>> _______________________________________________ Ltp-list mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/ltp-list >>>> >>>> >>> >>> >> > > ------------------------------------------------------------------------------ > This SF.net Dev2Dev email is sponsored by: > > Show off your parallel programming skills. > Enter the Intel(R) Threading Challenge 2010. > http://p.sf.net/sfu/intel-thread-sfd > _______________________________________________ > Ltp-list mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ltp-list > > ------------------------------------------------------------------------------ This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
