Hi! > > Some aio_suspend tests are redundantly, so we should remove them. > > > > Signed-off-by: Bian Naimeng <[email protected]> > > > > ------ > > > > .../conformance/interfaces/aio_suspend/6-1.c | 217 > > ------------------ > > .../conformance/interfaces/aio_suspend/7-1.c | 242 > > -------------------- > > .../conformance/interfaces/aio_suspend/8-1.c | 240 > > ------------------- > > .../conformance/interfaces/aio_suspend/9-1.c | 242 > > -------------------- > > 4 files changed, 0 insertions(+), 941 deletions(-) > > This implies that the tests are broken and need to be fixed (see > assertions.xml for more details about what the tests need to test).
Well this is a little more complicated, when looking on the assertions: 4-1.c On a timeout exit, aio_suspend shall return with an error. 7-1.c aio_suspend() shall return the value -1 and set errno to indicate error if it returns before at least one AIO operation have completed. These test may not be similar, but as the interrupt is generated by timeout in 7-1.c code for these two tests is similar (except for the test name). Sometimes I think that the people writing these test were payed per code line, so copy & paste was preffered solution. -- Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more! http://p.sf.net/sfu/dell-eql-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
