Cyril Hrubis wrote:
> Hi!
>>> Some aio_suspend tests are redundantly, so we should remove them.
>>>
>>> Signed-off-by: Bian Naimeng <[email protected]>
>>>
>>> ------
>>>
>>> .../conformance/interfaces/aio_suspend/6-1.c | 217
>>> ------------------
>>> .../conformance/interfaces/aio_suspend/7-1.c | 242
>>> --------------------
>>> .../conformance/interfaces/aio_suspend/8-1.c | 240
>>> -------------------
>>> .../conformance/interfaces/aio_suspend/9-1.c | 242
>>> --------------------
>>> 4 files changed, 0 insertions(+), 941 deletions(-)
>> This implies that the tests are broken and need to be fixed (see
>> assertions.xml for more details about what the tests need to test).
>
en... , after reading assertions and posix SPEC, i think we just
need test following points.
case1. aio_suspend should return after a IO request complete.
case2. aio_suspend should return after timeout.
case3. aio_suspend can be interrupted by signal not notify a request
completion.
case4. if the list contains null pointers, they should are ignored.
Actually, case1 has implemented by 1-1, case2 has implemented by 4-1,
case3 is not exist, case4 has implemented by 3-1.
So, i think we should get rid of 6-1,7-1,8-1 and 9-1, then add the case3.
If you agree with me, i will pass a new patch to add the case3.
Thanks
Bian
> Well this is a little more complicated, when looking on the assertions:
>
> 4-1.c
>
> On a timeout exit, aio_suspend shall return with an error.
>
> 7-1.c
>
> aio_suspend() shall return the value -1 and set errno to indicate error
> if it returns before at least one AIO operation have completed.
>
>
> These test may not be similar, but as the interrupt is generated by
> timeout in 7-1.c code for these two tests is similar (except for the
> test name).
>
> Sometimes I think that the people writing these test were payed per code
> line, so copy & paste was preffered solution.
>
--
Regards
Bian Naimeng
------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture
Simplifying enterprise desktop deployment and management using
Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
