Hi! > I updated TOMOYO testcases for Linux 3.1. > http://sourceforge.jp/projects/tomoyo/svn/view/trunk/2.4.x/tomoyo-tools/kernel_test/tomoyo-ltp.diff?revision=5388&root=tomoyo > 4378 lines, 162,176 bytes. > MD5: 4b1ce1f661a9b102b44ae59e495ee3d6
I'm glad to see the patch, however there are a few things that needs to be settled before applying to LTP. * Please next time send the patch attached to the mail, ideally inlined as well as attachement. It's much easier for me to review it that way. Or even better If you had a git repository on sf.net I could pull changes directly from there. * Including <linux/sched.h> instead of <sched.h> may introduce problems in future. Look here how to fix the problem with sched.h: http://ltp.git.sourceforge.net/git/gitweb.cgi?p=ltp/ltp.git;a=commit;h=019ed6c71369217ac02c399abb12abb93bd527f3 The clone flags are GNU extensions and Ulrich 'fixed' these, so they aren't defined unless you say they should. There are some minor coding style violations and useless statements. But I don't think there is a reason to force you to fix them. Just let me know if you wan't to know ;). -- Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
