Hi!
> > * Please next time send the patch attached to the mail, ideally inlined
> >   as well as attachement. It's much easier for me to review it that way.
> >   Or even better If you had a git repository on sf.net I could pull
> >   changes directly from there.
> 
> I think this patch was too large. Does this ML accept such a large patch?
> Or, should I split into smaller patches for this ML?

Not sure about the ML settings, but it should work, the worse that could
happen is being hold for moderator to approve the mail.

Yes ideally I would like to see the patches being split into reasonable
bits. Its easier to keep track what has changed and why this way.

> > * Including <linux/sched.h> instead of <sched.h> may introduce problems
> >   in future.
> > 
> >   Look here how to fix the problem with sched.h:
> 
> Two weeks ago I received a report from Clemens Fischer that tomoyo-tools does
> not build on Arch-Linux system with rolling releases
> ('uname -rms' -> Linux 3.0.1-spott i686) because CLONE_NEWNS is not defined by
> including <sched.h> . Thus, I added including <linux/sched.h> if CLONE_NEWNS 
> is
> not defined by including <sched.h> (as shown below).
> I'll contact Clemens to try _GNU_SOURCE instead of including <linux/sched.h> .

Defining _GNU_SOURCE should do the trick, just keep in mind that this
must be defined before you include any libc headers.

-- 
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better 
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to