On 11/01/2012 10:10 AM, Linliangjie wrote: > Issue description: > ------------------- > Kernel Version : 3.7-rc2 > System call : ioctl > LTP Testcase : ioctl01 > LTP Version : 20120903 > Platform : x86_64 ( HP 8200 PC ) > Testcase Description : Testcase to check the errnos set by the ioctl(2) system > call. > Previous kernel version in which testcase passed : 3.2.9 > > Executing log: > ------------------------- > [root@linux-qf4g]-[/tmp/ltp/ltp/testcases/bin] > (0)# ./ioctl01 -D /dev/tty > ioctl01 1 TPASS : failed as expected: TEST_ERRNO=EBADF(9): Bad file > descriptor > ioctl01 2 TPASS : failed as expected: TEST_ERRNO=EFAULT(14): Bad > address > ioctl01 3 TFAIL : failed unexpectedly; expected 22 - Invalid argument: > TEST_ERRNO=ENOTTY(25): Inappropriate ioctl for device > ioctl01 4 TPASS : failed as expected: TEST_ERRNO=ENOTTY(25): > Inappropriate ioctl for device > ioctl01 5 TPASS : failed as expected: TEST_ERRNO=EFAULT(14): Bad > address > ------------------------- > The return value of the code is expected to be 22 but 24 is returned and > hence the LTP test failed. > >>From v3.2.9, kernel has changed the return value for bad command. > The patch commit no:07d106d0a33d6063d2061305903deb02489eba20
Yes, you are right, but you didn't find the real effective patch, the real effective patch is commit bbb63c514a3464342967237a51a21ea8f61ab951 Author: Wanlong Gao <[email protected]> Date: Mon Aug 27 15:23:12 2012 +0800 drivers:tty:fix up ENOIOCTLCMD error handling At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be translated as ENOTTY to user mode. For example: fd = open("/dev/tty", O_RDWR); ioctl(fd, -1, &argp); then the errno should be ENOTTY but not EINVAL. Signed-off-by: Wanlong Gao <[email protected]> Acked-by: Alan Cox <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> It's a kernel change, so I will make a patch to fix this LTP test case. Thank you very much for reporting this. ;) And you *Huawei* guys are very welcome to the Open Source community. :-) Regards, Wanlong Gao ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
