On 11/02/2012 05:48 PM, Caspar Zhang wrote: > On 11/02/2012 04:51 PM, Wanlong Gao wrote: >> As linus said at the below commit, >> commit 07d106d0a33d6063d2061305903deb02489eba20 >> Author: Linus Torvalds <[email protected]> >> Date: Thu Jan 5 15:40:12 2012 -0800 >> >> vfs: fix up ENOIOCTLCMD error handling >> >> We're doing some odd things there, which already messes up various users >> (see the net/socket.c code that this removes), and it was going to add >> yet more crud to the block layer because of the incorrect error code >> translation. >> >> ENOIOCTLCMD is not an error return that should be returned to user mode >> from the "ioctl()" system call, but it should *not* be translated as >> EINVAL ("Invalid argument"). It should be translated as ENOTTY >> ("Inappropriate ioctl for device"). >> >> That EINVAL confusion has apparently so permeated some code that the >> block layer actually checks for it, which is sad. We continue to do so >> for now, but add a big comment about how wrong that is, and we should >> remove it entirely eventually. In the meantime, this tries to keep the >> changes localized to just the EINVAL -> ENOTTY fix, and removing code >> that makes it harder to do the right thing. >> >> Return ENOTTY is right. And with the tty driver change with below commit, >> commit bbb63c514a3464342967237a51a21ea8f61ab951 >> Author: Wanlong Gao <[email protected]> >> Date: Mon Aug 27 15:23:12 2012 +0800 >> >> drivers:tty:fix up ENOIOCTLCMD error handling >> >> At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be >> translated as ENOTTY to user mode. >> For example: >> fd = open("/dev/tty", O_RDWR); >> ioctl(fd, -1, &argp); >> >> then the errno should be ENOTTY but not EINVAL. >> >> Reported-by: Jack Lin <[email protected]> >> Suggested-by: Jan Stancek <[email protected]> >> Signed-off-by: Wanlong Gao <[email protected]> > > Reviewed-by: Caspar Zhang <[email protected]>
Pushed, thank you all involved. Wanlong Gao ------------------------------------------------------------------------------ LogMeIn Central: Instant, anywhere, Remote PC access and management. Stay in control, update software, and manage PCs from one command center Diagnose problems and improve visibility into emerging IT issues Automate, monitor and manage. Do more in less time with Central http://p.sf.net/sfu/logmein12331_d2d _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
