On 13 March 2013 17:22, Mike Frysinger <[email protected]> wrote:
>>
>> -#if defined(__hppa__)
>> +#if defined(__hppa__) || (__metag__)
>
> you're missing "defined"
>

Looking a couple of lines above this I see the following:

#if defined (__s390__) || (__s390x__)

so I assumed this is the desired style for multiple "#if defined" constructs.

But if you want me to rewrite the patch so include the missing
"defined" let me know.

>>       ret = clone(fn, stack, clone_flags, arg);
>>  #elif defined(__ia64__)
>>       ret = clone2(fn, stack, stack_size, clone_flags, arg, NULL, NULL, 
>> NULL);
>
> i wonder if we could make this into a runtime test.  like declare a buffer on
> the stack, then call alloca(), and compare the resulting pointers.
> -mike

If you ask me, I prefer the way it is now.

-- 
Regards,
Markos Chandras

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to