On 14 March 2013 16:52, Mike Frysinger <[email protected]> wrote: > On Wednesday 13 March 2013 13:28:08 Markos Chandras wrote: >> On 13 March 2013 17:22, Mike Frysinger wrote: >> >> -#if defined(__hppa__) >> >> +#if defined(__hppa__) || (__metag__) >> > >> > you're missing "defined" >> >> Looking a couple of lines above this I see the following: >> >> #if defined (__s390__) || (__s390x__) >> >> so I assumed this is the desired style for multiple "#if defined" >> constructs. > > nope, that's a bug too
Ok I will fix that too in v2 > >> >> ret = clone(fn, stack, clone_flags, arg); >> >> >> >> #elif defined(__ia64__) >> >> >> >> ret = clone2(fn, stack, stack_size, clone_flags, arg, NULL, NULL, >> >> NULL); >> > >> > i wonder if we could make this into a runtime test. like declare a >> > buffer on the stack, then call alloca(), and compare the resulting >> > pointers. >> >> If you ask me, I prefer the way it is now. > > the advantage is that the next random person to grow their stock in the > opposite direction won't have to update this hard coded list. and if it was > written this way earlier, you wouldn't be here right now either ;). > > not saying you must do this ... fix the defined checks and we can merge that > -mike Ok but we rarely need to touch this list (how often do you see explicit #if/defs for new arches in LTP, especially with the stack growing upwards?). But sure, making this check during runtime would also be nice. Patch v2 sent. -- Regards, Markos Chandras ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
