----- Original Message ----- > From: [email protected] > To: "Markos Chandras" <[email protected]> > Cc: [email protected] > Sent: Monday, 18 March, 2013 1:15:09 PM > Subject: Re: [LTP] [PATCH v4] syscalls/getdents: Add parameter to test > getdents64 syscall > > Hi! > > + if (longsyscall) > > + free(dirp64); > > + else > > + free(dirp); > > + > > cleanup(); > > > > tst_exit(); > > You don't need to bother to free the buffers when the next thing the > test does is exit, the whole heap along with malloc data structures > will > be freed (unmapped) by the kernel anyway.
I think it's nice thing to cleanup. Say, if test corrupted heap, free could alert you. Also there are tools, which may complain, that there's a leak now. I think LTP supports at least valgrind. Regards, Jan > > -- > Cyril Hrubis > [email protected] > > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_mar > _______________________________________________ > Ltp-list mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ltp-list > ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
