On 18 March 2013 13:46, Jan Stancek <[email protected]> wrote: > > > ----- Original Message ----- >> From: [email protected] >> To: "Jan Stancek" <[email protected]> >> Cc: [email protected], "Markos Chandras" >> <[email protected]> >> Sent: Monday, 18 March, 2013 2:26:27 PM >> Subject: Re: [LTP] [PATCH v4] syscalls/getdents: Add parameter to test >> getdents64 syscall >> >> Hi! >> > > You don't need to bother to free the buffers when the next thing >> > > the >> > > test does is exit, the whole heap along with malloc data >> > > structures >> > > will >> > > be freed (unmapped) by the kernel anyway. >> > >> > I think it's nice thing to cleanup. Say, if test corrupted heap, >> > free could alert you. Also there are tools, which may complain, >> > that there's a leak now. I think LTP supports at least valgrind. >> >> So what about compromise, defining them as variables instead of the >> allocation? > > That would work. You really want that free() gone, don't you? :-). >
Yeah I was about to ask the same thing. I see no problem with keeping free() around and I don't think there is an urgent need to convert these pointers to variables. -- Regards, Markos Chandras ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
