On 05/30/2013 09:03 PM, chru...@suse.cz wrote:
> Hi!
>>> This patch fixes parallel build error. When use parallel build
>>>
>>> with -j16 or -j8, $(CRITICAL_MAKEFILES) are created as empty file
>>>
>>> because generate-makefiles is called several times. So need to
>>>
>>> disable parallel build.
>>>
>>> The following code can guarantee sequencial building.
>>>
>>> .NOTPARALLEL: $(CRITICAL_MAKEFILES)
>>
>> The problem is that Open Posix Testsuite should stuck with POSIX make.
>> At least we promise that we will not break it actively. Now the 2008
>> POSIX make still does not support the idea of parallel build. I will
>> have a look what will other than GNU make implementations do with such
>> rule. If it would be ignored then we are fine adding it, if not we will
>> have to figure out how to detect GNU make and add the line accordingly.
> 
> I got a an idea how to fix this in portable fashion. The key is the
> order of filenames the make looks for.
> 
> The gnu make tries GNUmakefile first, then makefile or Makefile.
> 
> So if we create GNUmakefile, which would include the Makefile and adds
> the .NOTPARALLEL: target it should work both with both GNU make and any
> other POSIX conforming make out there.

Well, good idea. ;)
So, Jungsoo, would you mind make a patch following this idea?

Thanks,
Wanlong Gao

> 


------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite
It's a free troubleshooting tool designed for production
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to