> Hi!
> > > This patch fixes parallel build error. When use parallel build
> > >
> > > with -j16 or -j8, $(CRITICAL_MAKEFILES) are created as empty file
> > >
> > > because generate-makefiles is called several times. So need to
> > >
> > > disable parallel build.
> > >
> > > The following code can guarantee sequencial building.
> > >
> > > .NOTPARALLEL: $(CRITICAL_MAKEFILES)
> >
> > The problem is that Open Posix Testsuite should stuck with POSIX make.
> > At least we promise that we will not break it actively. Now the 2008
> > POSIX make still does not support the idea of parallel build. I will
> > have a look what will other than GNU make implementations do with such
> > rule. If it would be ignored then we are fine adding it, if not we
> > will have to figure out how to detect GNU make and add the line
> accordingly.
>
> I got a an idea how to fix this in portable fashion. The key is the order
> of filenames the make looks for.
>
> The gnu make tries GNUmakefile first, then makefile or Makefile.
>
> So if we create GNUmakefile, which would include the Makefile and adds
> the .NOTPARALLEL: target it should work both with both GNU make and any
> other POSIX conforming make out there.
I think your idea is good.
But I think that the code to distinguish GNU make and other POSIX will makes
the Makefile to be more complex.
I do not wish to complicate the Makefile more than is necessary.
How about using '-j1' without '.NOTPARALLEL:' option as follows.
This patch fixes parallel build error. When use parallel build
with -j16 or -j8, $(CRITICAL_MAKEFILES) are created as empty file
because generate-makefiles is called several times. So need to
disable parallel build.
Signed-off-by: jungsoo.son <jungsoo....@lge.com>
---
testcases/open_posix_testsuite/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/testcases/open_posix_testsuite/Makefile
b/testcases/open_posix_testsuite/Makefile
index 9c61fa4..3bfb5a5 100644
--- a/testcases/open_posix_testsuite/Makefile
+++ b/testcases/open_posix_testsuite/Makefile
@@ -38,7 +38,8 @@ datadir?= $(prefix)/share
exec_prefix?= $(prefix)
-all: conformance-all functional-all stress-all tools-all
+all:
+ @$(MAKE) -j1 conformance-all functional-all stress-all tools-all
clean: $(CRITICAL_MAKEFILES)
@rm -f $(LOGFILE)*
--
1.7.9.5
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite
It's a free troubleshooting tool designed for production
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
