On Tue, Jun 25, 2013 at 3:36 PM, Sedat Dilek <[email protected]> wrote:
> On Tue, Jun 25, 2013 at 3:33 PM,  <[email protected]> wrote:
>> Hi!
>>> >> Hmm, if I remeber correctly there dash that is used as /bin/sh on Debian
>>> >> (and supposedly on Ubuntu) that does not understand the &> syntax so the
>>> >> messages may be reversed because the commands are executed on background
>>> >> (instead of the output redirected to /dev/null).
>>> >>
>>> >
>>> > Yeah, dash is default.
>>> > I try with using bash instead.
>>> >
>>>
>>> YUPP, that worked :-).
>>>
>>
>> I will fix the script to work with dash and commit the fix to git.
>>
>> Thanks for the testing.
>>
>
> Removing that dash-incompatibility makes runltp work again.
>

Aaargh, copied wrong around.

# diff -uprN runltp.orig runltp_be-dash-compatible
--- runltp.orig 2013-06-25 15:33:06.613356674 +0200
+++ runltp_be-dash-compatible   2013-05-03 14:01:55.043063967 +0200
@@ -663,7 +663,7 @@ main()
     fi

     # check for required users and groups
-    ${LTPROOT}/IDcheck.sh || \
+    ${LTPROOT}/IDcheck.sh &>/dev/null || \
     {
         echo "WARNING: required users and groups not present"
         echo "WARNING: some test cases may fail"
@@ -984,7 +984,7 @@ main()
 create_block()
 {
     #create a block device with ext4 filesystem.
-    dd if=/dev/zero of=${TMP}/test.img bs=1kB count=10240
+    dd if=/dev/zero of=${TMP}/test.img bs=1kB count=10240 &>/dev/null
     if [ $? -ne 0 ]; then
         echo "Failed to create loopback device image, please check
disk space and re-run"
         return 1
@@ -996,12 +996,12 @@ create_block()
             return 1
         else
             ##attach the created file to loop dev.
-            losetup $LOOP_DEV ${TMP}/test.img
+            losetup $LOOP_DEV ${TMP}/test.img &>/dev/null
             if [ $? -ne 0 ]; then
                 echo "losetup failed to create block device"
                 return 1
             else
-                mkfs.ext4 $LOOP_DEV
+                mkfs.ext4 $LOOP_DEV &>/dev/null
                 [ $? -ne 0 ] && (echo "creating a ext4 block device
failed" && return 1)
                 #set the values in alltests which require block device.
                 DEVICE=$LOOP_DEV

- Sedat -

> - Sedat -
>
>> --
>> Cyril Hrubis
>> [email protected]

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to