Hi! > >> +# create an ext4 partition > >> +dd if=/dev/zero of=fs_ext4_new_features_$$.img bs=1M count=$BLOCK_COUNT > >> + > >> +if [ $? -ne 0 ];then > >> + tst_brkm TCONF ignored "failed to create an ext4 image file" > >> + exit 0 > >> +fi > >> + > >> +EXT4_DEV=$(losetup --show -f fs_ext4_new_features_$$.img) > >> +if [ $? -ne 0 ];then > >> + tst_brkm TCONF ignored "set loop device failed" > >> + exit 0 > >> +fi > >> + > >> +echo "EXT4_DEV=$EXT4_DEV" > ./ext4-test-config > >> + > > We should use DEVICE passed to the runltp script instead, that way we > > don't even need this helper (if there is some common code move it to > > ex4_funcs.sh and use it from the tests) and call the test scripts > > from runtest file directly. > > The ext4 new features test need a big partition, and the recommended > size of this partition is between 5G and 10G, so the DEVICE isn't appropriate. > > Whether I should create a big partition in runltp script named BIG_DEVICE to > run these tests? >
Sounds reasonable to me. -- Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
