On 2013/11/26 22:49, [email protected] wrote:
> Hi!
>> +include $(top_srcdir)/include/mk/generic_trunk_target.mk
>> diff --git a/testcases/network/rpc/basic_tests/rpc01/datafiles/Makefile
>> b/testcases/network/rpc/basic_tests/rpc01/datafiles/Makefile
>> new file mode 100644
>> index 0000000..92370e6
>> --- /dev/null
>> +++ b/testcases/network/rpc/basic_tests/rpc01/datafiles/Makefile
>> @@ -0,0 +1,29 @@
>> +#
>> +# network/rpc/basic_tests/rpc01/datafiles Makefile.
>> +#
>> +# This program is free software; you can redistribute it and/or modify
>> +# it under the terms of the GNU General Public License as published by
>> +# the Free Software Foundation; either version 2 of the License, or
>> +# (at your option) any later version.
>> +#
>> +# This program is distributed in the hope that it will be useful,
>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> +# GNU General Public License for more details.
>> +#
>> +# You should have received a copy of the GNU General Public License along
>> +# with this program; if not, write to the Free Software Foundation, Inc.,
>> +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>> +#
>> +# Simon Xu <[email protected]> Nov 8 2013
>> +#
>> +
>> +top_srcdir ?= ../../../../../..
>> +
>> +include $(top_srcdir)/include/mk/env_pre.mk
>> +
>> +INSTALL_DIR := testcases/bin/datafiles
> We allready have a testcases/data/ directory that is used by the unzip
> testcase, what about using this one instead?
testcases/bin/datafiles is used by several tests
~/devel/ltp/testcases/network > grep -r datafiles *
Makefile:DIR := datafiles
nfs/nfslock01/nfslock01:# datafiles are compared.
nfs/nfs02/nfs02:TCdat=${TCdat:=$TCbin/datafiles}
rpc/basic_tests/rpc01/rpc01:TCdat=${TCdat:=$TCbin/datafiles}
tcp_cmds/ftp/ftp01: TCdat=${TCdat:-$LTPROOT/datafiles}
tcp_cmds/Makefile:INSTALL_DEPS := ../datafiles/bin.sm
tcp_cmds/Makefile:../datafiles/bin.sm:
tcp_cmds/rcp/rcp01: TCdat=${TCdat:-$LTPROOT/testcases/bin/datafiles}
tcp_cmds/Makefile.inc:# network/tcp_cmds datafiles dependent include
Makefile.
tcp_cmds/Makefile.inc:MAKE_DEPS :=
$(GENERATE_FILE_DIR)/datafiles/bin.sm
tcp_cmds/rdist/rdist01: TCdat=${TCdat:-$LTPROOT/testcases/bin/datafiles}
tcp_cmds/sendfile/sendfile01:
TCdat=${TCdat:-$LTPROOT/testcases/bin/datafiles}
I think we better change all of them or do nothing.
Thanks
Simon
>> +INSTALL_TARGETS := file*
> Can you please also rename the data files so that it's clear that they
> are part of the rpc test? Something like rpc01_file1 rpc01_file2 or
> similar should do. Or we can start stacking the files into
> subdirectories named after the testcase, i.e.
> testcases/data/rpc01/file1
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
