On 2013/11/27 19:49, [email protected] wrote: > Hi! >> testcases/bin/datafiles is used by several tests >> >> ~/devel/ltp/testcases/network > grep -r datafiles * >> Makefile:DIR := datafiles >> nfs/nfslock01/nfslock01:# datafiles are compared. >> nfs/nfs02/nfs02:TCdat=${TCdat:=$TCbin/datafiles} >> rpc/basic_tests/rpc01/rpc01:TCdat=${TCdat:=$TCbin/datafiles} >> tcp_cmds/ftp/ftp01: TCdat=${TCdat:-$LTPROOT/datafiles} >> tcp_cmds/Makefile:INSTALL_DEPS := ../datafiles/bin.sm >> tcp_cmds/Makefile:../datafiles/bin.sm: >> tcp_cmds/rcp/rcp01: TCdat=${TCdat:-$LTPROOT/testcases/bin/datafiles} >> tcp_cmds/Makefile.inc:# network/tcp_cmds datafiles dependent include >> Makefile. >> tcp_cmds/Makefile.inc:MAKE_DEPS := >> $(GENERATE_FILE_DIR)/datafiles/bin.sm >> tcp_cmds/rdist/rdist01: TCdat=${TCdat:-$LTPROOT/testcases/bin/datafiles} >> tcp_cmds/sendfile/sendfile01: >> TCdat=${TCdat:-$LTPROOT/testcases/bin/datafiles} > Ah, I guess there are at least two more places where tests install their > data files. I've looked around and found a few in testcases/bin/ :( > >> I think we better change all of them or do nothing. > Right. I want to have one single place to store test datafiles and > ideally to be easy to figure out which files belogs to which testcases. > Once this is defined we can fix all the testcases as well. > > What about this: > > 1. Testcases datafiles are stored in a TESTNAME_data directory > where TESTNAME is name of the test or a group of test (if > the files are used by more than one test) > > 2. The whole directory gets installed somewhere in the > /opt/ltp/testcases/, be it testcases/bin/datafiles or > testcases/datafiles. > > What do you think?
What about testcases/data/TESTNAME? Thanks Simon ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
