On 08/22/2014 12:05 PM, Wanlong Gao wrote:
> On 08/22/2014 02:45 PM, Jan Stancek wrote:
>> Older kernels (2.6.32) on ppc64 return EINVAL instead of ENOMEM.
>>
>> Man page says:
>> "EINVAL We don’t like addr, length, or offset (e.g., they are too large,
>> or not aligned on a page boundary).", which suggests that both
>> ENOMEM and EINVAL should be considered.
>>
>> Signed-off-by: Jan Stancek <jstan...@redhat.com>
>
> Acked-by: Wanlong Gao <gaowanl...@cn.fujitsu.com>
Modern sparc64 kernels return EINVAL as well.
Acked-by: Stanislav Kholmanskikh <stanislav.kholmansk...@oracle.com>
>
>> ---
>> testcases/kernel/syscalls/mmap/mmap15.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/testcases/kernel/syscalls/mmap/mmap15.c
>> b/testcases/kernel/syscalls/mmap/mmap15.c
>> index 49dbba4..f1fc267 100644
>> --- a/testcases/kernel/syscalls/mmap/mmap15.c
>> +++ b/testcases/kernel/syscalls/mmap/mmap15.c
>> @@ -80,10 +80,10 @@ int main(int ac, char **av)
>> continue;
>> }
>>
>> - if (errno != ENOMEM) {
>> + if (errno != ENOMEM && errno != EINVAL) {
>> tst_resm(TFAIL | TERRNO, "mmap into high region "
>> "failed unexpectedly - expect "
>> - "errno=ENOMEM, got");
>> + "errno=ENOMEM/EINVAL, got");
Maybe add this ENOMEM/EINVAL in the comment few stings above:
/* Attempt to mmap into highmem addr, should get ENOMEM */
?
Thanks.
>> } else {
>> tst_resm(TPASS | TERRNO, "mmap into high region "
>> "failed as expected");
>>
>
>
> ------------------------------------------------------------------------------
> Slashdot TV.
> Video for Nerds. Stuff that matters.
> http://tv.slashdot.org/
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
