On 22 August 2014 21:35, Stanislav Kholmanskikh
<stanislav.kholmansk...@oracle.com> wrote:
>
...
>>> ---
>>> testcases/kernel/syscalls/mmap/mmap15.c | 4 ++--
>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/testcases/kernel/syscalls/mmap/mmap15.c
>>> b/testcases/kernel/syscalls/mmap/mmap15.c
>>> index 49dbba4..f1fc267 100644
>>> --- a/testcases/kernel/syscalls/mmap/mmap15.c
>>> +++ b/testcases/kernel/syscalls/mmap/mmap15.c
>>> @@ -80,10 +80,10 @@ int main(int ac, char **av)
>>> continue;
>>> }
>>>
>>> - if (errno != ENOMEM) {
>>> + if (errno != ENOMEM && errno != EINVAL) {
>>> tst_resm(TFAIL | TERRNO, "mmap into high region "
>>> "failed unexpectedly - expect "
>>> - "errno=ENOMEM, got");
>>> + "errno=ENOMEM/EINVAL, got");
>
> Maybe add this ENOMEM/EINVAL in the comment few stings above:
> /* Attempt to mmap into highmem addr, should get ENOMEM */
>
> ?
Agree! It's a good proposal.
Last time I had a discussion with Cyril about this issue, but finally
we all think that's belong to the kernel problem.
http://thread.gmane.org/gmane.linux.ltp/20844/focus=20946
Since different kernel version have different kind of returned value,
so we should consider all of the situation for LTP.
Anyway, here Jan's succinct and lucid codes solved the different
kernel version conflict testing, it's very good. :)
>
> Thanks.
>
>>> } else {
>>> tst_resm(TPASS | TERRNO, "mmap into high region "
>>> "failed as expected");
>>>
>>
>>
--
Regards,
Li Wang
Email: wangli.a...@gmail.com
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
