ext4_get_inode_version.sh use $EXT4_DEV, but it really don't known what is $EXT4_DEV. That cause other cases which use ext4_get_inode_version.sh will failed.
Signed-off-by: Zorro Lang <zl...@redhat.com> --- Hi, When I run ext4-inode-version, I always hit TFAIL. But I can't reproduce the fail manually. Then I find ext4_inode_version_test.sh use ext4_get_inode_version.sh, ext4_get_inode_version.sh $EXT4_DEV which ext4_get_inode_version.sh don't know what it is. About this patch, I export $EXT4_DEV in ext4_inode_version_test.sh, before it use ext4_get_inode_version.sh. But I think add the "export" in front of "EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh will be another method. Please review, and tell me which one do you think is better for LTP? Or you have a better one;) Thank you, Zorro Lang .../fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh index ac8f021..2549088 100755 --- a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh +++ b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh @@ -138,6 +138,8 @@ test_inode_version() # main ext4_setup +# export EXT4_DEV for ext4_get_inode_version.sh can know it +export EXT4_DEV=$EXT4_DEV ext4_test_128_inode_version -- 1.9.3 ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
