On Mon, Nov 10, 2014 at 12:07:20PM +0300, Stanislav Kholmanskikh wrote: > Hi! > > On 10/31/2014 04:39 PM, Han Pingtian wrote: > >Hey there, > > > >I found that looks like all chown test cases will be compiled to 16 bit > >compat test case, but they just call chown() something like > > > > TEST(chown(fname, uid, gid)); > > > >which won't test if there is a 16 bit chown() syscall. I think maybe we > >should change it to something like below: > > > > TEST(CHOWN(fname, uid, guid)); > > > >then define CHOWN like this > > > > UID_T CHOWN(void (cleanup)(void)) > > { > > LTP_CREATE_SYSCALL(chown, cleanup); > > } > > > >? > > I think, this is a good idea. > > And there are more such test cases, which are not fixed for the 16-bit > compat case. For example, setresuid. > > So if it's possible, fixing them will be good as well;) > Looks like those cases need to be fixed for the 16-bit compat, right?
chown0[1-5] fchown0[1-5] lchown03 setresgid0[1-4] setresuid0[1-3,5] ------------------------------------------------------------------------------ Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list