On Fri, Nov 28, 2014 at 06:39:27PM +0300, Stanislav Kholmanskikh wrote: > > > On 11/28/2014 11:33 AM, Han Pingtian wrote: > > On Mon, Nov 24, 2014 at 05:53:32PM +0300, Stanislav Kholmanskikh wrote: > >> Hi. > >> > >> In general, it looks good. > >> > >> I have only one comment, that it's possible that the uid/gid values we pass > >> to the syscall may not fit into UID_T/GID_T. For example, when we get uid > >> of > >> nobody user in runtime and pass it to chown() or etc. > >> > >> Yes, it's more like an artificial case, but it's. > >> > >> We have UID16_CHECK and GID16_CHECK macros to check if the uid/gid fits the > >> compat mode. > >> > >> What do you think about using it in test cases chown01, chown03, chown04, > >> fchown01, fchown03, fchown04, setresgid*, setresuid* ? > >> > >> Thank you. > > > > Please review new patch which included UID16_CHECK and GID16_CHECK. > > > > Thanks. > > Hi! > > I pushed your patch with TCID_DEFINE added (overlooked it at that time), > and also pushed a follow-up patch which: > * fixes setresuid02_16, setresuid03_16, setresuid04_16 - they do > testing inside their children. > * explicitly declares setresuid(), setresgid() in compat_16.h. This is > to manage compilation warnings. > > Tested in OL6 with 2.6.39-400.215.11.el6uek.x86_64 and > 2.6.39-400.214.5.el6uek.i686 kernels. > > Thank you. > Thanks!
------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
