Hi!
> > diff --git a/testcases/kernel/power_management/runpwtests.sh 
> > b/testcases/kernel/power_management/runpwtests.sh
> > index 9055964..0a66dc4 100755
> > --- a/testcases/kernel/power_management/runpwtests.sh
> > +++ b/testcases/kernel/power_management/runpwtests.sh
> > @@ -42,6 +42,7 @@ YES=0
> >  NO=1
> >  #List of reusable functions defined in pm_include.sh
> >  . pm_include.sh
> > +. pm_check_env.sh
> 
> Is the same check needed in more than one file?
> 
> Because if it's not there is no need to move it into separate file...

Ah, you split the file into separate testcases later. This change should
rather be part of that patch, or the reason why you move the check out
of the file should be part of the commit message for this patch.
Otherwise it does not make sense.

-- 
Cyril Hrubis
chru...@suse.cz

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to