Hi, On 02/09/2015 10:10 PM, Cyril Hrubis wrote: > Hi! >> -# testcases/kernel/power_management requires python. >> -if test "x$with_python" = xyes; then >> - AC_ARG_WITH([power-management-testsuite], >> - [AC_HELP_STRING([--with-power-management-testsuite], >> - [compile and install the x86 power management testsuite >> (default=no)])], >> - [with_power_management_testsuite=yes], >> - ) >> -fi >> -if test "x$with_power_management_testsuite" = xyes; then >> - AC_SUBST([WITH_POWER_MANAGEMENT_TESTSUITE],["yes"]) >> -else >> - AC_SUBST([WITH_POWER_MANAGEMENT_TESTSUITE],["no"]) >> -fi > > Well, it's true that the testsuite needs python, so technically this is > correct but I agree that this is not the best way to do that. > > The question is, does the testsuite need python in compile or install > phase? If not we can safely remove this and change it to runtime check. >
After investigation, I think the testsuite doesn't need python in compile and install phase, so I remove it. >> AC_ARG_WITH([open-posix-testsuite], >> [AC_HELP_STRING([--with-open-posix-testsuite], >> [compile and install the open posix testsuite (default=no)])], >> diff --git a/include/mk/features.mk.default b/include/mk/features.mk.default >> index c9edc1c..69425ca 100644 >> --- a/include/mk/features.mk.default >> +++ b/include/mk/features.mk.default >> @@ -34,13 +34,6 @@ HAVE_SECUREBITS := no >> >> # Test suite knobs >> >> -# Enable testcases/kernel/power_management's compile and install? >> -ifeq ($(UCLINUX),1) >> -WITH_POWER_MANAGEMENT_TESTSUITE := no >> -else >> -WITH_POWER_MANAGEMENT_TESTSUITE := >> -endif > > What is wrong with these configure knobs? > > I think that this is far better than the runtime test you introduced in > later patches. > It is not wrong with these configure knobs. Sorry, I make a mistake in this. I will modify it. Thanks! regards, Xing Gu ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
