Hi,
On 05/06/2015 01:18 PM, Wei,Jiangang wrote:
> Compare size_t size elements with file data and check
> if it's excpeted.
> This patch depends on bff5968.
>
> Signed-off-by: Wei,Jiangang <[email protected]>
> ---
> testcases/kernel/syscalls/fallocate/fallocate04.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/fallocate/fallocate04.c
> b/testcases/kernel/syscalls/fallocate/fallocate04.c
> index a6d1159..2da0bcd 100644
> --- a/testcases/kernel/syscalls/fallocate/fallocate04.c
> +++ b/testcases/kernel/syscalls/fallocate/fallocate04.c
> @@ -174,7 +174,7 @@ static void test02(void)
> fill_tst_buf(exp_buf);
> memset(exp_buf + block_size, 0, block_size);
>
> - check_file_data(exp_buf);
> + check_file_data(exp_buf, sizeof(exp_buf)/sizeof(exp_buf[0]));
Thank you for fixing it.
We could you use size variables already defined for 'exp_buf[buf_size]'.
>
> tst_resm(TPASS, "test-case succeeded");
> }
> @@ -214,7 +214,7 @@ static void test03(void)
> fill_tst_buf(exp_buf);
> memset(exp_buf + block_size - 1, 0, block_size + 2);
>
> - check_file_data(exp_buf);
> + check_file_data(exp_buf, sizeof(exp_buf)/sizeof(exp_buf[0]));
>
Also buf_size variable here.
> tst_resm(TPASS, "test-case succeeded");
> }
> @@ -250,7 +250,7 @@ static void test04(void)
> memcpy(exp_buf, tmp_buf, block_size);
> memcpy(exp_buf + block_size, tmp_buf + size, block_size);
>
> - check_file_data(exp_buf);
> + check_file_data(exp_buf, sizeof(exp_buf)/sizeof(exp_buf[0]));
>
'size' variable here.
> tst_resm(TPASS, "test-case succeeded");
> }
Now test04 fails because I forgot to set adjacent two bytes in 'exp_buf'
to zero in test04(), it could be fixed as follows:
@@ -250,8 +249,8 @@ static void test04(void)
memcpy(exp_buf, tmp_buf, block_size);
memcpy(exp_buf + block_size, tmp_buf + size, block_size);
-
- check_file_data(exp_buf);
+ exp_buf[block_size - 1] = exp_buf[block_size] = '\0';
+ check_file_data(exp_buf, size);
tst_resm(TPASS, "test-case succeeded");
}
I think it would be better to merge fallocate04 fixes in a single patch.
Thanks,
Alexey
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
