On 05/12/2015 01:43 PM, Wanlong Gao wrote:
> On 05/07/2015 05:54 PM, Wei, Jiangang wrote:
>> On Thu, 2015-05-07 at 12:37 +0300, Alexey Kodanev wrote:
>>> Hi,
>>> On 05/07/2015 09:17 AM, Wei,Jiangang wrote:
>>>> Using 'sizeof' on array given as function argument
>>>> returns size of a pointer, instead of the array's.
>>>> So,
>>>> It needs to pass an additional parameter size_t size
>>>> indicating the number of elements in the array.
>>>>
>>>> Besides above,
>>>> Set adjacent two bytes in 'exp_buf' to zero in test04().
>>>>
>>>> Signed-off-by: Wei,Jiangang <weijg.f...@cn.fujitsu.com>
>>>> ---
>>>> testcases/kernel/syscalls/fallocate/fallocate04.c | 10 +++++-----
>>>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/testcases/kernel/syscalls/fallocate/fallocate04.c
>>>> b/testcases/kernel/syscalls/fallocate/fallocate04.c
>>>> index 723c886..911bbe8 100644
>>>> --- a/testcases/kernel/syscalls/fallocate/fallocate04.c
>>>> +++ b/testcases/kernel/syscalls/fallocate/fallocate04.c
>>>> @@ -98,9 +98,8 @@ static void setup(void)
>>>> get_blocksize();
>>>> }
>>>>
>>>> -static void check_file_data(const char exp_buf[])
>>>> +static void check_file_data(const char exp_buf[], size_t size)
>>>> {
>>>> - size_t size = sizeof(exp_buf);
>>>> char rbuf[size];
>>>>
>>>> tst_resm(TINFO, "reading the file, compare with expected buffer");
>>>> @@ -175,7 +174,7 @@ static void test02(void)
>>>> fill_tst_buf(exp_buf);
>>>> memset(exp_buf + block_size, 0, block_size);
>>>>
>>>> - check_file_data(exp_buf);
>>>> + check_file_data(exp_buf, buf_size);
>>>>
>>>> tst_resm(TPASS, "test-case succeeded");
>>>> }
>>>> @@ -215,7 +214,7 @@ static void test03(void)
>>>> fill_tst_buf(exp_buf);
>>>> memset(exp_buf + block_size - 1, 0, block_size + 2);
>>>>
>>>> - check_file_data(exp_buf);
>>>> + check_file_data(exp_buf, buf_size);
>>>>
>>>> tst_resm(TPASS, "test-case succeeded");
>>>> }
>>>> @@ -251,7 +250,8 @@ static void test04(void)
>>>> memcpy(exp_buf, tmp_buf, block_size);
>>>> memcpy(exp_buf + block_size, tmp_buf + size, block_size);
>>>>
>>>> - check_file_data(exp_buf);
>>>> + exp_buf[block_size - 1] = exp_buf[block_size] = '\0';
>>>> + check_file_data(exp_buf, size);
>>>>
>>>> tst_resm(TPASS, "test-case succeeded");
>>>> }
>>>
>>> Patch applied, thank you!
>>
>> Thank you for your feedback so quickly.
>> Do you have noticed the other commit?
>> ->[PATCH 3/3] kernel/mem/mmapstress: fix resource leak
>>
>> I guess it might have been ignored...
>
> It's a bit messy, would you repost your patches which were
> not applied to make things more clearly?
And start a new mail thread.
Thanks,
Wanlong Gao
>
> Thanks,
> Wanlong Gao
>
>>
>> Thanks again,
>> Wei
>>>
>>> Best regards,
>>> Alexey
>>>
>>>
>>
>> ------------------------------------------------------------------------------
>> One dashboard for servers and applications across Physical-Virtual-Cloud
>> Widest out-of-the-box monitoring support with 50+ applications
>> Performance metrics, stats and reports that give you Actionable Insights
>> Deep dive visibility with transaction tracing using APM Insight.
>> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
>> _______________________________________________
>> Ltp-list mailing list
>> Ltp-list@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/ltp-list
>> .
>>
>
> .
>
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
