Hi, On 05/22/2015 05:21 PM, Jan Stancek wrote: > ----- Original Message ----- >> From: "Zeng Linggang" <zenglg...@cn.fujitsu.com> >> To: "Alexey Kodanev" <alexey.koda...@oracle.com> >> Cc: ltp-list@lists.sourceforge.net, "vasily isaenko" >> <vasily.isae...@oracle.com> >> Sent: Thursday, 21 May, 2015 7:39:37 AM >> Subject: [LTP] [PATCH] fallocate04: Use tst_kvercmp after lseek(SEEK_HOLE) >> return EINVAL >> >> SEEK_HOLE is only supported since version 3.1. Just print some >> information to remind users if kernel is before 3.1, if not print >> 'TBROK' and quit, instead of 'TWARN'. > Looks OK to me. Alexey, any objections from your side?
Sorry for the delay, looks good to me. There is stylistic comment below, but it is minor: >> - tst_resm(TWARN | TERRNO, "lseek() doesn't support SEEK_HOLE"); >> + if (tst_kvercmp(3, 1, 0) < 0) >> + tst_resm(TINFO, "lseek() doesn't support SEEK_HOLE, " >> + "this is expected for < 3.1 kernels"); >> + else >> + tst_brkm(TBROK | TERRNO, cleanup, >> + It would be better to add curly braces around multiline 'if else' block. Thanks, Alexey ------------------------------------------------------------------------------ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
