----- Original Message -----
> From: "Cyril Hrubis" <chru...@suse.cz>
> To: "Jan Stancek" <jstan...@redhat.com>
> Cc: "Xiaoguang Wang" <wangxg.f...@cn.fujitsu.com>,
> ltp-list@lists.sourceforge.net
> Sent: Monday, 20 July, 2015 3:39:39 PM
> Subject: Re: [LTP] [PATCH] syscalls/getrandom: add configure check for
> linux/random.h
>
> Hi!
> > I see the difference. RHEL5.11GA has autoconf-2.59-12, which is too old
> > for LTP, it requires autoconf >= 2.61. Test we run internally upgrades
> > it to higher version.
> >
> > If I use the absolute minimum of autoconf/automake versions, I get:
> > configure: WARNING: linux/random.h: present but cannot be compiled
> > configure: WARNING: linux/random.h: check for missing prerequisite
> > headers?
> > configure: WARNING: linux/random.h: see the Autoconf documentation
> > configure: WARNING: linux/random.h: section "Present But Cannot Be
> > Compiled"
> > configure: WARNING: linux/random.h: proceeding with the preprocessor's
> > result
> > configure: WARNING: linux/random.h: in the future, the compiler will take
> > precedence
> >
> > Notice the last line. I think that's why it worked for me - I used version,
> > where
> > it already took compiler result as default.
> >
> > So I think your patch is still needed for older versions, but I'd remove
> > the call to getrandom() and keep the name "HAVE_LINUX_RANDOM_H".
>
> So the problem is that the distribution has too old autoconf? I think
> that requiring to generate the configure script with newer autoconf
> isn't insane requirement (the released tarballs include ready-to-use
> configure script anyway). And generating it yourself on new enough
> distro and uploading it isn't too much work either.
>
> So what about instead of working around older autoconf we abort the
> process with big fat message that newer autoconf is needed in this case?
In that case we are talking about something as:
diff --git a/configure.ac b/configure.ac
index 0198ac7..9081681 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,4 +1,4 @@
-AC_PREREQ(2.61)
+AC_PREREQ(2.64)
AC_INIT([ltp], [LTP_VERSION], [ltp-list@lists.sourceforge.net])
AC_CONFIG_AUX_DIR([.])
AM_INIT_AUTOMAKE
2.64 version is the first one, where AC_CHECK_HEADERS takes compiler
results as preferred one.
All RHEL6 minor releases are at "autoconf-2.63", so it may inconvenience
some new people, who were fine with 2.61 and may not have anything newer
around to generate configure. I'd personally prefer the workaround
and stay at "AC_PREREQ(2.61)".
Regards,
Jan
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
