----- Original Message -----
> From: "Xiaoguang Wang" <wangxg.f...@cn.fujitsu.com>
> To: "Jan Stancek" <jstan...@redhat.com>
> Cc: "Cyril Hrubis" <chru...@suse.cz>, ltp-list@lists.sourceforge.net
> Sent: Monday, 20 July, 2015 1:30:38 PM
> Subject: Re: [LTP] [PATCH] syscalls/getrandom: add configure check for
> linux/random.h
>
> hello Jan,
>
> On 07/13/2015 09:18 PM, Jan Stancek wrote:
> >
> >
> > ----- Original Message -----
> >> From: "Cyril Hrubis" <chru...@suse.cz>
> >> To: "Jan Stancek" <jstan...@redhat.com>
> >> Cc: ltp-list@lists.sourceforge.net
> >> Sent: Monday, 13 July, 2015 3:03:03 PM
> >> Subject: Re: [LTP] [PATCH] syscalls/getrandom: add configure check for
> >> linux/random.h
> >>
> >> Hi!
> >>> Old distros (such as RHEL5.6) break, when they try to include
> >>> some kernel headers directly. Add configure check to make sure
> >>> linux/random.h kernel header can be compiled without errors.
> >>
> >> Looks good to me, acked.
> >
> > Pushed.
> Sorry for late.
> It seems that your patch just checks the existence of 'linux/random.h'. In
> RHEL5.11GA,
Hmm, I tried older RHEL5 release, which gave me:
configure: WARNING: linux/random.h: present but cannot be compiled
configure: WARNING: linux/random.h: check for missing prerequisite
headers?
so compilation worked fine for me.
I'll install 5.11GA and give that a try.
> there is such header file, so still there are compilation errors. Could you
> please
> have a look at this patch, thanks.
I don't think the check should call "getrandom()", it's not defined by
linux/random.h,
and tests are using ltp_syscall anyway.
Regards,
Jan
>
> Regards,
> Xiaoguang Wang
> >
> > Regards,
> > Jan
> >
> >>
> >> --
> >> Cyril Hrubis
> >> chru...@suse.cz
> >>
> > .
> >
>
>
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
