Hi,

another solution could be to let ns_ifmove.c as it is (so it won't build)
and only add a check for binaries:
tst_check_cmds ns_create ns_exec ns_ifmove

to the netns test code. On the other hand, this will produce unclear
output from the netns testcases, you will only know that ns_ifmove
binary is unavailable, but won't know why.

The other way, as you pointed out, would be to check for kernel version
and propagate TCONF to the netns_helper.sh. The patch which adds what we
need ('IFLA_NET_NS_PID') to the kernel is:
http://lists.linuxfoundation.org/pipermail/containers/2007-September/007113.html

Matus


----- Original Message -----
From: "Cyril Hrubis" <chru...@suse.cz>
To: "Guangwen Feng" <fenggw-f...@cn.fujitsu.com>
Cc: ltp-list@lists.sourceforge.net, jjabu...@redhat.com
Sent: Tuesday, September 1, 2015 1:42:30 PM
Subject: Re: [LTP] LTP release

Hi!
> > I've did my release testing and pushed a few fixes, mosty minor ones.
> > 
> > Now the only problem that that blocks the release on my side are
> > failures of the newly rewritten netns testcases that were discussed
> > last week.
> > 
> 
> In RHEL5.11GA, ns_ifmove.c gives compilation error since 'IFLA_NET_NS_PID'
> undeclared in the kernel.

Looks like we need a configure check for the enum constant and way to
propagate TCONF from the ns_ifmove to the netns_helper.sh.

I will look into this.

-- 
Cyril Hrubis
chru...@suse.cz

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to