Petr Machata <[email protected]> writes:

> Dima Kogan <[email protected]> writes:
>
>> Petr Machata <[email protected]> writes:
>>
>>> Dima, I think you should be able to verify whether the second
>>> dwfl_nextcu iterates over the first module's data as well.  While that's
>>> probably harmless, it's a work duplication, and a better design would be
>>> to store Dwfl_Module at struct library and use dwfl_module_nextcu as
>>> indicated above.
>>
>>    no duplicate CUs are being processed in either case.
>
> I understand what's happening.  In proc.c, you look at
> proc->leader->dwfl, and use that if it's present.  If it's not, you
> create a new one.  But then you only store it at lib->dwfl, never at
> proc->leader->dwfl.  Only when -w is active is proc->leader->dwfl
> actually initialized, in which case the duplication scenario does occur.

Hmmm. I still don't see the duplication. Have you observed it?

_______________________________________________
Ltrace-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/ltrace-devel

Reply via email to