Petr Machata <[email protected]> writes: > Faraz Shahbazker <[email protected]> writes: > >> 2. mips_unresolved_data is shallow copied for each cloned symbol. If a >> child detaches whilst a symbol remains in NEED_UNRESOLVE state, then >> we shouldn't free its unresolve_data because the parent/siblings may >> still need it. I've added a ref_count field to the struct to fix this. >> I am not sure how(if at all) PPC tackles this problem. > > Looking in, I don't think it does. That's probably a bug, I'll need to > address that. Good catch!
Uh, of course it does. I _though_ this sounded familiar--I was fixing a bug in that cloning recently. But I was looking at pmachata/mips where the bug wasn't yet fixed ;) > The refcounting is fine by me, but for ppc I'll just do deep copy. > Easier to get right, I feel. It does a deep copy. Thanks, Petr _______________________________________________ Ltrace-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/ltrace-devel
