Date: Wed, 25 Jan 2012 14:21:34 -0500
From: Mathieu Desnoyers <[email protected]>
Message-ID: <20120125192134.GE10043@Krystal>

> > +           /*
> > +            * The signal handler will null sessiond_pid on SIGCHLD

> should be "will nullify"

   Editing the patch accordingly:

------------------------------
>From e64074d0a731607834d01e6e2da75955e8f793c4 Wed, 25 Jan 2012 13:50:18 -0500
From: Daniel U. Thibault <[email protected]>
Date: Wed, 25 Jan 2012 13:50:08 -0500
Subject: [PATCH] Explain the if (!session_pid) in lttng-tools lttng.c 
spawn_sessiond()

diff --git a/src/bin/lttng/lttng.c b/src/bin/lttng/lttng.c
index 95ef848..36723be 100644
--- a/src/bin/lttng/lttng.c
+++ b/src/bin/lttng/lttng.c
@@ -332,6 +332,9 @@
                while (!recv_child_signal) {
                        sleep(1);
                }
+               /*
+                * The signal handler will nullify sessiond_pid on SIGCHLD
+                */
                if (!sessiond_pid) {
                        exit(EXIT_FAILURE);
                }
------------------------------

Daniel U. Thibault
R & D pour la défense Canada - Valcartier (RDDC Valcartier) / Defence R&D 
Canada - Valcartier (DRDC Valcartier)
Système de systèmes (SdS) / System of Systems (SoS)
Solutions informatiques et expérimentations (SIE) / Computing Solutions and 
Experimentations (CSE)
2459 Boul. Pie XI Nord
Québec, QC  G3J 1X5
CANADA
Vox : (418) 844-4000 x4245
Fax : (418) 844-4538
NAC: 918V QSDJ
Gouvernement du Canada / Government of Canada
<http://www.valcartier.drdc-rddc.gc.ca/>

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Reply via email to