On 07/31/2013 06:00 PM, Jérémie Galarneau wrote:
> Hi Stefan,
>
> Please inline your patches in the future as it makes the review process
> simpler.
> There are a number of stylistic problems, mostly misplaced braces.
>
> You can run your patches through the checkpatch.pl script found in
> lttng-tools/extras. It will spot most coding-style related problems
> right away.
OK, will do, once the patch is approved functionally.
> Also, I think lttng-ust-pthread-mutex.c may be a more appropriate name
> than pthread.c
Wouldn't that just be redundant ? (And I actually expect the file to
grow instrumentation that's not mutex-specific.)
Thanks,
Stefan
--
...ich hab' noch einen Koffer in Berlin...
_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
